bug: fix deadlock when having multiple websocket listeners in anchor-client#4250
Open
cryptopapi997 wants to merge 3 commits intosolana-foundation:masterfrom
Open
bug: fix deadlock when having multiple websocket listeners in anchor-client#4250cryptopapi997 wants to merge 3 commits intosolana-foundation:masterfrom
anchor-client#4250cryptopapi997 wants to merge 3 commits intosolana-foundation:masterfrom
Conversation
|
@cryptopapi997 is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
anchor-client
Contributor
Author
|
wdyt @jamie-osec |
jamie-osec
reviewed
Feb 28, 2026
20f02c4 to
0a6beb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we create a new listener using
.on, it does the following:This means if we want to listen to two events at once, the second listener will hang on aquiring the write-lock forever, as the first event listener will hold its read-lock until it exits. This is unneccesary, since we just need to write if the websocket listener doesn't exist yet, so a read-lock would do. This PR fixes that.
For verification of the existence of this bug, here's a quick MRE also (just run solana-test-validator in a separate terminal first and then run this & observe how it hangs forever):